Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): Update OpenmrsDatePicker props #358

Closed
wants to merge 1 commit into from
Closed

(chore): Update OpenmrsDatePicker props #358

wants to merge 1 commit into from

Conversation

NethmiRodrigo
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR updates the onChange function of the OpenmrsDatePicker following the update done to it on the core

Screenshots

Related Issue

Other

@NethmiRodrigo NethmiRodrigo mentioned this pull request Aug 1, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Size Change: -1 B (0%)

Total Size: 1.19 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 300 kB 0 B
dist/184.js 11.2 kB 0 B
dist/194.js 9.51 kB 0 B
dist/225.js 2.57 kB 0 B
dist/277.js 1.84 kB 0 B
dist/300.js 709 B 0 B
dist/335.js 967 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 6.79 kB 0 B
dist/474.js 116 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 756 B 0 B
dist/635.js 14.3 kB 0 B
dist/674.js 86.4 kB 0 B
dist/70.js 482 B 0 B
dist/776.js 3.2 kB 0 B
dist/888.js 259 kB 0 B
dist/99.js 690 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 358 kB -1 B (0%)
dist/openmrs-form-engine-lib.js 3.72 kB 0 B

compressed-size-action

@NethmiRodrigo
Copy link
Contributor Author

@denniskigen could you please help out with the failing tests?

@ODORA0
Copy link
Member

ODORA0 commented Aug 5, 2024

@NethmiRodrigo When are we having this PR merged? It'll unblock failing to save forms because of the broken date issue.

@NethmiRodrigo
Copy link
Contributor Author

Closing this PR since the date picker update props got merged in with #359

@NethmiRodrigo NethmiRodrigo deleted the chore/update-datepicker branch August 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmale samuelmale samuelmale approved these changes

@ibacher ibacher ibacher approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NethmiRodrigo @ODORA0 @samuelmale @ibacher